Add Cyrus-SASL to our CI #1988
Merged
Add Cyrus-SASL to our CI #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1988 +/- ##
==========================================
+ Coverage 78.51% 78.88% +0.36%
==========================================
Files 585 593 +8
Lines 99681 101933 +2252
Branches 14271 14450 +179
==========================================
+ Hits 78265 80405 +2140
- Misses 20779 20885 +106
- Partials 637 643 +6 ☔ View full report in Codecov by Sentry. |
skmcgrail
approved these changes
Nov 13, 2024
samuel40791765
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
CryptoAlg-2554Description of changes:
Add Cyrus-SASL to our CI
Call-outs:
There is no general testing suite for Cyrus. To test the GSSAPI with Kerberos, we can use provided sample_client and sample_server applications. However, this requires a working Kerberos setup with a KDC and another script to support communication between the sample_client and server programs. This is not being added as of now.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.